Repository navigation
Fix #1080 - domain memory leak. - #1083
Conversation
Domains are created per request rather than creating a single domain for all requests. This kills the memory leak, as a single domain would keep a reference to every single req and res, causing rapid heap growth.
|
See #1080. After applying this fix, The heap sits at about 90MB after the stress test, as opposed to just over 300MB before this patch.
We should consider how we might write a test for |
|
Not sure what Travis' problem is, the |
|
LGTM |
Fix #1080 - domain memory leak.
|
Let's talk about how to write a test for this (new issue?) This went unnoticed in my test environments due to lower API traffic and caused several crashes in production. |
|
Sure, do you have any ideas in mind to measure/verify the memory footprint? For example, http://nodejs.org/api/process.html#process_process_memoryusage? Maybe we should have a set of |
|
I think we should do some basic client/server stress test in a |
|
When can we expect a release? This is a critical leak. |
|
This release is very important for us, Many our servers are consuming a expensive CPU and memory. |
Domains are created per request rather than creating a single
domain for all requests. This kills the memory leak, as a single
domain would keep a reference to every single req and res, causing
rapid heap growth.